Closed
Conversation
cibuildwheel seems to set a thread number automatically. My previous code to set threads is unnecessary and adds complexity.
It is unlikely that this would be triggered multiple times, but given that it's possible to run this workflow manually, it's best to guard against accidental concurrent execution.
`cibuildwheel` does not run `twine check`. It makes sense to run this quick check as part of building & testing wheels. [`check-wheel-contents`](https://github.com/jwodder/check-wheel-contents) is a utility that performs other checks on the wheel structure, such as whether there are extraneous files or directories in the wheel.
- Add support for manually publishing to TestPyPI - When debug is true, use verbose flag to publishing action - Set permissions on upload job - Update job names and timeouts
MacOS and Linux top-level structures are different, and at the moment I don't see a way of setting alternate values for different platforms.
1de4e87 to
04d3dea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the workflows for publishing wheels. The main changes are:
cibuildwheelstep inreusable_build_wheels.yaml. These check the structure of the wheels in ways that cibuildwheel does not.